Telemetry via serial port #97
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds end-to-end serial telemetry support by exposing available ports in the frontend, wiring up selection in the dashboard, and implementing serial read logic in the backend.
- Introduce a new
SerialSelectorcomponent and embed it in the Dashboard UI - Add
/serial-infoand/connect-deviceendpoints and aserial_readloop in backend comms - Update dependencies (
pyserial) and adjust startup logging inmain.py
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Frontend/src/Components/SerialSelector/SerialSelector.js | New component to list and select serial devices and baud rates |
| Frontend/src/Components/Dashboard/Dashboard.js | Import and layout <SerialSelector/> in the dashboard grid |
| Frontend/src/Components/Communication/Communication.js | Add serial status label; removed solar car connection label |
| Backend/setup.py | Add pyserial to install_requires |
| Backend/main.py | Set uvicorn log level to critical |
| Backend/core/core_api.py | Implement /serial-info GET and /connect-device POST routes |
| Backend/core/comms.py | Add serial_read thread, update packet parsing for serial input |
| Backend/.gitignore | Ignore files from file sync downloads |
Comments suppressed due to low confidence (4)
Backend/core/comms.py:146
- The
timemodule is used here but not imported; addimport timeat the top of the file.
if(time.time() - latest_tstamp > 5):
Frontend/src/Components/Communication/Communication.js:55
- The Solar Car Connection label was removed—if displaying that status is intended, re-add this
CommsLabel.
<CommsLabel
boolean={props.data?.solar_car_connection[0]}
label='Solar Car Connection'
/>
Backend/core/comms.py:178
- The
tracebackmodule is used without import; addimport tracebackat the top of the file.
print(traceback.format_exc())
Backend/main.py:14
- [nitpick] Using
log_level='critical'silences most runtime logs; consider a less restrictive default or make it configurable.
uvicorn.run(app='main:app', host="0.0.0.0", port=config.HOST_PORT, log_level='critical')
| } | ||
| }) | ||
| .then((body) => { | ||
| setSelectedDevice(body['connected_device']['device']); // Set default device |
There was a problem hiding this comment.
Refreshing the selected device on every interval will override the user's choice. Consider only setting the default on initial mount or when selectedDevice is empty.
| setSelectedDevice(body['connected_device']['device']); // Set default device | |
| if (!selectedDevice) { // Only set default device if no device is selected | |
| setSelectedDevice(body['connected_device']['device']); | |
| } |
| width={'30%'} | ||
| padding={2} | ||
| value={selectedBaud} | ||
| onChange={e => setSelectedBaud(e.target.value)} |
There was a problem hiding this comment.
e.target.value is a string but selectedBaud is numeric—wrap with parseInt(e.target.value, 10) to ensure the state stays a number.
| onChange={e => setSelectedBaud(e.target.value)} | |
| onChange={e => setSelectedBaud(parseInt(e.target.value, 10))} |
| header = b'<bsr>' | ||
| footer = b'</bsr>' | ||
| header = b"<bsr>" | ||
| footer = b"<bsr" |
There was a problem hiding this comment.
Footer tag is missing the closing slash—should be b'</bsr>' to match the regex and proper packet parsing.
| footer = b"<bsr" | |
| footer = b"</bsr>" |
No description provided.